Step 1: Buy Prowlers
Step 2: Use Prowlers on the objective
Step 3: Smite the objective for 1035 true damage!
External link →Step 1: Buy Prowlers
Step 2: Use Prowlers on the objective
Step 3: Smite the objective for 1035 true damage!
External link →If true damage isn't reduced by resistances, why is it increased by things like Abyssal Mask, Prowlers, etc.? Seems like it's only situationally "true"
On a technical level, it's just how the items/debuffs are coded.
I don't think it was really intentional; more of an oversight. I could be wrong.
I would expect that true damage was a class at this point, and that things like this shouldn't be possible. But I guess the legacy code is too spaghetti to fix.
Also, it should be standard developer practice to create a unit test to check obvious stuff like this on all spells or items that increases or reduces damage. I'm really curious about how much of this is bad practice, and how much is just working on a system that was poorly coded and got too big to fix.
Bugs obviously do happen everywhere, but for things like true damage the system itself should prevent a single developer from "forgetting" or messing up.
I mean, it's very easy to just tell the ability "amplify magic and physical damage" instead of "amplify all damage."
After all, exceptions are useful. Ahri's Charm impacts the back half of Q. If true damage is hard coded to ignore all damage modifiers, you get way more issues than just making sure you build the skills or buffs correctly.