[2020] Why does this thing come up every time I try to make a new world?

Going to guess antivirus - more specifically anti-ransomware protection on the My Documents folder.

Check whatever AV you are using (even windef does this) and make sure terraria is allowed access.