This stays as long as it doesn't break anything. Bugs can be great features.
This stays as long as it doesn't break anything. Bugs can be great features.
it does unfortunately. I reversed the game a bit and realized you can write all the control stuff you guys do to exit text appearance.
For example, I can get the game to crash (break the parser) by naming my weapon:
<p><font size="0
edit: even shorter: <p><p
obviously exploiting these non terminated sequences could quickly become a problem. I could imagine naming weapons and patching your game to handle the failed control characters could allow you to crash other clients. RCE is unlikely though due to the small amount of characters you can use. At most this is a DOS.
(RCE being possible assuming the error is producing undefined behaviour and not just an uncaught std::exception or whatever)
Rats. We will have to fix some stuff, then.